Skip to content

Rename directory for ship .so files to be ship instead of release #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

rasaha91
Copy link

@rasaha91 rasaha91 commented Nov 5, 2021

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Office has special build variables that allow specifying paths to flavor specific binaries at a single location. In order for this to work however, it is expected that the directories are named debug and ship, instead of debug and release. This change simply renames the directory that hermes release .so files are copied to from "release" to "ship".

Changelog

[Android] [Fixed] - Copy release hermes related binaries to a directory named ship instead of release

Test Plan

Created a draft PR which published the android nuget package, which I then copied locally and ran a ship build to ensure the build works as expected

@rasaha91 rasaha91 requested review from mganandraj and a team November 5, 2021 00:10
@rasaha91 rasaha91 requested a review from alloy as a code owner November 5, 2021 00:10
@acoates-ms acoates-ms merged commit 28f2b13 into 0.64-stable Nov 5, 2021
@acoates-ms acoates-ms deleted the rasaha-0.64-stable branch November 5, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants