Skip to content

Add nullability type #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Conversation

HeyImChris
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

We have more strict warning -> error checks downstream and one of the checks requires the block pointer to have a nullability type.

Changelog

[Bug] [iOS/macOS] - Add nullability check

Test Plan

Just fixes up a warning- if CI passes then everything should be clear.

Sorry, something went wrong.

@HeyImChris HeyImChris self-assigned this Nov 8, 2021
@HeyImChris HeyImChris requested a review from alloy as a code owner November 8, 2021 22:54
@pull-bot
Copy link

pull-bot commented Nov 8, 2021

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 4545eca

@acoates-ms acoates-ms merged commit 21e2955 into microsoft:master Nov 9, 2021
@acoates-ms acoates-ms mentioned this pull request Nov 9, 2021
acoates-ms added a commit that referenced this pull request Nov 9, 2021
acoates-ms added a commit that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants