Skip to content

Add nullable check #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

HeyImChris
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

There's one more spot we need a nullable type specifier due to downstream deps having the -Wnullability-completeness flag enabled.

Test Plan

Shouldn't affect user scenarios, but if it builds then should be all set.

@HeyImChris HeyImChris requested a review from alloy as a code owner November 10, 2021 00:35
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 8bfd961

@harrieshin
Copy link

similar to other pr, are we suppressing some warning?

@HeyImChris HeyImChris merged commit 1f2c7ed into microsoft:0.64-stable Nov 10, 2021
@HeyImChris
Copy link
Author

similar to other pr, are we suppressing some warning?

These warnings aren't suppressed but downstream we have warnings set to throw errors which breaks our builds. We still get the warnings here but no one's taken the time to fix these warnings yet.

@anandrajeswaran
Copy link

similar to other pr, are we suppressing some warning?

These warnings aren't suppressed but downstream we have warnings set to throw errors which breaks our builds. We still get the warnings here but no one's taken the time to fix these warnings yet.

I would argue that a warning not being treated as an error means it is effectively suppressed. If it doesn't break CI there isn't any real practical difference between whether a warning shows up or it doesn't. Ultimately should try to turn on warnings as errors and push that upstream as soon as possible as it really shouldn't be too bad to eliminate this class of failures if indeed we have it solved downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants