Skip to content

Remove the redundant reactnativejniutils .so from packaging #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

msgharpu
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • [👍] I am making a change required for Microsoft usage of react-native

Summary

libreactnativeutilsjni.so is a redundant library added in RN 64. This is just a subset of libreactnativejni.so. It is linked while building the fabric components. We are not using fabric components in our internal use cases hence having this library in package leads to unnecessary increase in apk size. In this PR we remove this library from packaging.

Changelog

  • Modified the android-patches folder to apply a new set of patches which remove the dependency on libreactnativeutilsjni.so
  • Modified android-patches for Nuspec file to exclude the library from packaging
  • Modified the yml file to apply patches from one more folder

[CATEGORY] [TYPE] - Message

Test Plan

  • Verified with existing RN use cases in Android

@harrieshin harrieshin merged commit a76dff9 into microsoft:0.64-stable Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants