-
Notifications
You must be signed in to change notification settings - Fork 147
Alert presenting vc master #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alert presenting vc master #920
Conversation
* scene support for alerts * move alert changes
It looks like a bunch of Android files had line endings that VSCode on my Mac doesn't agree with. Probably fair to fix up those line endings too so these files stop showing up as "changed" on other peoples' machines. |
@@ -1,27 +1,27 @@ | |||
@if "%DEBUG%" == "" @echo off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unintentional change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this in another comment on the review. I think VSCode on Mac didn't like the current line endings. I can just fix them up now since they're already on my machine
@@ -1,89 +1,89 @@ | |||
@rem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this in another comment on the review. I think VSCode on Mac didn't like the current line endings. I can just fix them up now since they're already on my machine
|
Please select one of the following
Summary
Pull in a 0.64-stable fix to master
git cherry-pick b7752ec
Changelog
[Bug] [macOS] - Cherry pick alert fix
Test Plan
Tested in downstream app when it was opened in 0.64-stable branch