Skip to content

Package .so files in AAR File #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Conversation

msgharpu
Copy link

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • [👍 ] I am making a change required for Microsoft usage of react-native

Summary

The native .so files were missing from AAR packaging. This change adds it back

Changelog

Remove excludeLibs parameter from build command

@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 719fcc8

@HeyImChris HeyImChris merged commit ae77351 into microsoft:0.64-stable Dec 20, 2021
rasaha91 pushed a commit to rasaha91/react-native-macos that referenced this pull request Mar 18, 2022
* Package .so files in AAR File

* Ensure that Ndk Libs are built before packaging

Co-authored-by: Mayuresh Gharpure <[email protected]>
rasaha91 pushed a commit to rasaha91/react-native-macos that referenced this pull request Mar 19, 2022
* Package .so files in AAR File

* Ensure that Ndk Libs are built before packaging

Co-authored-by: Mayuresh Gharpure <[email protected]>
rasaha91 pushed a commit to rasaha91/react-native-macos that referenced this pull request Mar 19, 2022
* Package .so files in AAR File

* Ensure that Ndk Libs are built before packaging

Co-authored-by: Mayuresh Gharpure <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants