You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our main branch isn't stable yet. I think this is because we've been doing our 0.66 merge in the fb66merge branch of @HeyImChris 's fork.
While main isn't stable, let's disable another failing CI check to not unblock merges. We should track fixing this test (along with the disabled test in #945 ) because we will need nightly builds passing eventually.
📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.
CATEGORY may be:
General
macOS
iOS
Android
JavaScript
Internal (for changes that do not need to be called out in the release notes)
TYPE may be:
Added, for new features.
Changed, for changes in existing functionality.
Deprecated, for soon-to-be removed features.
Removed, for now removed features.
Fixed, for any bug fixes.
Security, in case of vulnerabilities.
MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖
📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖
📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
Can we just fix this test instead of disabling it? The fix lives in 0.66 so should be doable to track it down.
Sorry, feel free to ignore me till tomorrow.
We can, I just couldn't figure it yet. I assumed the test would start passing again whenever we merged the 0.66 merge branch.
Can we just fix this test instead of disabling it? The fix lives in 0.66 so should be doable to track it down.
Sorry, feel free to ignore me till tomorrow. We can, I just couldn't figure it yet. I assumed the test would start passing again whenever we merged the 0.66 merge branch.
Yep test passes on 0.66! We'd just need a follow up to re-enable this test once 0.66 goes in which I'm hoping will be today.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
Our main branch isn't stable yet. I think this is because we've been doing our 0.66 merge in the fb66merge branch of @HeyImChris 's fork.
While main isn't stable, let's disable another failing CI check to not unblock merges. We should track fixing this test (along with the disabled test in #945 ) because we will need nightly builds passing eventually.