[0.64] Add onFocus/onBlur/onKeyDown/onKeyUp to Pressable #968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pink #962 into 0.64-stable
Please select one of the following
Summary
Closes #518
Pressable was missing the
onFocus/onBlur
callbacks, I guess we missed this when we first added those props toTouchable
. Let's go explicitly add them. I based my code off of the React Native Windows fork of Pressable.In the future, I would also like to add Space/Enter keyboarding defaults to Pressable like React Native Windows has, where onKey(Down|Up) of Space/Enter on a Pressable is equivalent to onPress(In|Out). However, that would need me to make significant changes to how keyboard events work on macOS, so I'll just be sure to expose them now and leave it for later.
Changelog
[macOS] [Fixed] - Pressable didn't expose onFocus/onBlur
Test Plan
Added tests to rn-tester which indeed show onFocus/onBlur are fired.