Skip to content

[0.64] Expose text tooltip #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jan 19, 2022

Cherry pick #960 into 0.64-stable

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

A client was reporting that tooltip wasn't showing up on the text component. This seems to be a simple one line fix.

Changelog

[macOS] [Fixed] - Fix Tooltip on Text not showing up

Test Plan

Checked the tooltip test page that tooltip on shows up.

Screen Shot 2022-01-14 at 10 28 53 PM

@Saadnajmi Saadnajmi requested a review from alloy as a code owner January 19, 2022 18:44
@Saadnajmi Saadnajmi changed the title expose text tooltip [0.64] Expose text tooltip Jan 19, 2022
@pull-bot
Copy link

Fails
🚫

❔ This pull request needs a description.

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against b8e7f0e

@Saadnajmi
Copy link
Collaborator Author

Closing till I get the CI in 0.64 in a better state

@Saadnajmi Saadnajmi closed this Jan 19, 2022
@Saadnajmi Saadnajmi reopened this Jan 21, 2022
@Saadnajmi Saadnajmi merged commit 509b080 into microsoft:0.64-stable Jan 21, 2022
@Saadnajmi Saadnajmi deleted the tooltip-64 branch January 21, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants