[0.64] Fix CI #973
Closed
[0.64] Fix CI #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* comment out test * Update run-ci-e2e-tests.js * Update run-ci-e2e-tests.js
|
HeyImChris
reviewed
Jan 20, 2022
scripts/run-ci-e2e-tests.js
Outdated
| @@ -280,12 +280,16 @@ try { | |||
| exitCode = 1; | |||
| throw Error(exitCode); | |||
| } | |||
| describe('Test: Flow check'); | |||
There was a problem hiding this comment.
Do we need this now that CI is optional?
There was a problem hiding this comment.
Good point, I can try un-commenting it and see what happens
There was a problem hiding this comment.
Yep, the CircleCI tests are optional! As such, this PR is no longer needed
HeyImChris
approved these changes
Jan 20, 2022
|
Closing as this PR should no longer be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #945 and whatever else I need to get CI green.
=====
Please select one of the following
Summary
The
Flow Checkphase of our End to End Circle CI tests fails. This seems to be because the E2E test is installing _react-native-macosversion 0.63 instead of latest (which is missing theColors.darker` variable, which is how I figured that out. I haven't figured it out yet (perhaps #944 will help?), but this is blocking PRs quite a bit. Let's comment it out for nowChangelog
[Internal] [Removed] - Removed Flow check test from E2E tests temporarily
Test Plan