Skip to content

Add --autogenerateVersionNumber flag for canary version in publish.yml #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amgleitman
Copy link
Member

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Add the --autogenerateVersionNumber flag for the bump-oss-version.js invocation in publish.yml.

This new flag was introduced with #989. While this ADO task won't get run in a non-main branch, we're still making it here for the sake of correctness.

@amgleitman amgleitman requested a review from alloy as a code owner January 27, 2022 02:00
@amgleitman amgleitman requested a review from acoates-ms January 27, 2022 02:00
@Saadnajmi
Copy link
Collaborator

We don't need the Android changes in #989 to fix the CI here?

@amgleitman
Copy link
Member Author

We don't need the Android changes in #989 to fix the CI here?

This is going into 0.66-stable, where #989 has already been applied. We'll be bringing these into main at a later date.

@Saadnajmi
Copy link
Collaborator

We don't need the Android changes in #989 to fix the CI here?

This is going into 0.66-stable, where #989 has already been applied. We'll be bringing these into main at a later date.

Ah, thought this was the one going to main my bad!

@amgleitman amgleitman merged commit 94527a1 into microsoft:0.66-stable Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants