Skip to content

Defork Yoga.cpp #7600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asklar opened this issue Apr 15, 2021 · 5 comments
Closed

Defork Yoga.cpp #7600

asklar opened this issue Apr 15, 2021 · 5 comments
Labels
Area: Layout bug Deforking

Comments

@asklar
Copy link
Member

asklar commented Apr 15, 2021

There seem to be multiple functional changes between RN core's Yoga.cpp and our fork
@asklar asklar added the bug label Apr 15, 2021
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 15, 2021
@NickGerleman
Copy link
Contributor

Duplicate of #3994

@NickGerleman NickGerleman marked this as a duplicate of #3994 Apr 21, 2021
@NickGerleman
Copy link
Contributor

There is a PR to Yoga which had the fixes from early last year, but the FB team owning it doesn't seem to be accepting contributions to the OSS version.

facebook/yoga#995

@NickGerleman
Copy link
Contributor

NickGerleman commented Apr 21, 2021 •
edited
Loading

@rozele is the above PR something you might be able to land FB-side?

@NickGerleman
Copy link
Contributor

BTW @asklar you can see a diff of our patches if you run npx react-native-platform-override diff path/to/Yoga.cpp

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 22, 2021
@rozele
Copy link
Contributor

rozele commented Sep 22, 2021 •
edited
Loading

@NickGerleman I just submitted a request to get the Yoga PR imported.

@ghost ghost added the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Sep 22, 2021
@chrisglein chrisglein removed the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Layout bug Deforking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@NickGerleman @rozele @asklar @chrisglein