Skip to content

Upstream Yoga Measurement Patches #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NickGerleman opened this issue Jan 30, 2020 · 2 comments
Closed

Upstream Yoga Measurement Patches #3994

NickGerleman opened this issue Jan 30, 2020 · 2 comments
Assignees
@sagokhal
Labels
Area: Layout Code Cleanup Deforking enhancement Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Milestone
Backlog

Comments

@NickGerleman
Copy link
Contributor

We patched Yoga to change measurement behavior with microsoft/react-native-macos#100. This requires us to maintain a separate copy of Yoga in react-native-windows. We should upstream our patch into facebook/react-native.

@acoates-ms was of the opinion we may want to put the change behind a preprocessor definition we would enable in RNW to avoid changing iOS/Android behavior.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 30, 2020
@NickGerleman NickGerleman removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 30, 2020
@NickGerleman NickGerleman mentioned this issue Feb 14, 2020
Closed
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Apr 9, 2020
@woehrl01
Copy link

@NickGerleman Hi, I just stumbled over that open issue. As I heavily contributed to https://github.com/facebook/yoga a few years ago, my recommendation would be to use YGExperimentalFeature* + YGConfigSetExperimentalFeatureEnabled for that, as it doesn't require a preprocessor. We actually added that behavior exactly for those cases.

You simply extend the sequence in YGEnum.h + adding the logic around that. You could then enable that behavior only for affected (sub-)trees.

@woehrl01 woehrl01 mentioned this issue May 30, 2020
Closed
@chrisglein chrisglein added this to the Backlog milestone Jul 17, 2020
@chrisglein chrisglein added Area: Layout and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jul 17, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 16, 2020
@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Sep 25, 2020
@NickGerleman NickGerleman mentioned this issue Apr 21, 2021
Closed
@TatianaKapos TatianaKapos mentioned this issue Dec 22, 2023
Closed
@marlenecota
Copy link
Contributor

It looks like microsoft/react-native-macos#100 patch was accidentally deleted in the 9/20/23 Integration (#12165). Yoga.cpp has since been deleted, so if this change is still needed, we will need to fork CalculateLayout.cpp.

@chiaramooney chiaramooney added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagokhal sagokhal

Labels
Area: Layout Code Cleanup Deforking enhancement Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@NickGerleman @marlenecota @woehrl01 @chrisglein @chiaramooney @sagokhal