Skip to content

Conversation

await component.waitForDisplayed({timeout: 5000});
const dump = await dumpVisualTree('image-network-callback');
expect(dump).toMatchSnapshot();
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiaramooney Just want to confirm that it's good to remove this test - in this PR upstream, the Image component attached to this test was removed: facebook/react-native#48619. Since there's is only one image left in this example, I removed the test for the second (now deleted) image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that's okay!

@Yajur-Grover Yajur-Grover marked this pull request as ready for review January 22, 2025 00:23
@Yajur-Grover Yajur-Grover requested review from a team as code owners January 22, 2025 00:23
@Yajur-Grover
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Yajur-Grover Yajur-Grover merged commit 89cd613 into microsoft:main Jan 23, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants