[Fabric] Added UIA Event Triggers for accessibilityAnnotation Property Changes #15039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change/react-native-windows-8aaaff79-a2a7-4bd6-af5f-ecee696abe44.json
Outdated
Show resolved
Hide resolved
vineethkuttan
requested changes
Aug 8, 2025
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
vineethkuttan
requested changes
Aug 8, 2025
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds UIA (UI Automation) event triggers for the accessibilityAnnotation property in React Native Windows. When accessibilityAnnotation property values change, the system will now properly raise UIA change events to notify accessibility tools.
Key changes:
- Added new overloaded UpdateUiaProperty function for long values
- Implemented UpdateUiaPropertiesForAnnotation function to handle all annotation property updates
- Integrated annotation property change notifications into the accessibility update workflow
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| UiaHelpers.h | Added function declarations for long value UIA updates and annotation property handling |
| UiaHelpers.cpp | Implemented UIA property update functions for annotation properties |
| CompositionViewComponentView.cpp | Integrated annotation property change notifications into accessibility update flow |
| change/react-native-windows-a648cb52-86ff-47b1-b2be-04d168a7f110.json | Added change file for version tracking |
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@gsaran25 Please don't remove the changelog section of PR description and add values appropriately. |
anupriya13
requested changes
Aug 11, 2025
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
anupriya13
approved these changes
Aug 11, 2025
vineethkuttan
approved these changes
Aug 11, 2025
vineethkuttan
changed the title
protikbiswas100
pushed a commit
that referenced
this pull request
Sep 10, 2025
… Changes (#15039) * Added UIA Event Triggers for accessibilityAnnotation Property Changes * Added UIA Event Triggers for accessibilityAnnotation Property Changes * wrapped to single call - UpdateUIAPropertiesForAnnotation * Annotation Props UIA Event method call * removed yarn change file * Review Changes done * UpdateUiaPropertyForAnnotation method removed. * UpdateUiaProperty long method param added. * yarn format changes * AccessibilityAnnotation default valued assigned. --------- Co-authored-by: Vineeth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The accessibilityAnnotation property was introduced in RNW. However, we did not implement logic to raise a UIA change event when its values are updated.
Type of Change
Why
The accessibilityAnnotation property was introduced in RNW. However, we did not implement logic to raise a UIA change event when its values are updated.
Resolves [#14999]
What
Added events for the below properties.
UIA_AnnotationAnnotationTypeIdPropertyId
UIA_AnnotationAnnotationTypeNamePropertyId
UIA_AnnotationAuthorPropertyId
UIA_AnnotationDateTimePropertyId
Screenshots
Developed in mac, Could not able to test.
Testing
Developed in mac, Could not able to test.
Changelog
Should this change be included in the release notes: yes
Add a brief summary of the change to use in the release notes for the next release.
Added UIA update event for change in annotation properties.
Microsoft Reviewers: Open in CodeFlow