Skip to content

Expose placeholder prop on Picker #6552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lyahdav
Copy link
Contributor

@lyahdav lyahdav commented Nov 17, 2020

This exposes the ComboBox PlaceholderText as a prop on Picker called placeholder.

Microsoft Reviewers: Open in CodeFlow

@lyahdav lyahdav requested a review from a team as a code owner November 17, 2020 22:35
@NickGerleman
Copy link
Contributor

@lyahdav the built-in Picker component is close to being jettisoned from react-native, and react-native-windows by proxy. E.g. the RNTester example for it was recently removed after the component has been deprecated for a few releases.

I'd definitely reccomend making any changes to the Picker community module, which supports Windows and has a very similar implementation. Not sure if FB's build system for RNW Would make that challenging, but it's likely this change will otherwise go away when the component is removed.

@NickGerleman
Copy link
Contributor

I think @rectified95 might have some additional context

@NickGerleman
Copy link
Contributor

Link to the community module. It looks like it does also have macos support https://github.com/react-native-picker/picker

@rectified95
Copy link
Contributor

I agree with Nick - this code is only here because it has not been removed from RN core yet after deprecation. The community module repo is the way to go - the change should map 1-1 there.

@lyahdav lyahdav closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants