Provide more TS type information for ViewWindows #8616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agniuks
approved these changes
Sep 10, 2021
|
@acoates-ms Not directly related to this PR, but I was curious if there might be a way to use this to provide info about windows-only inputs for RN-core props? -- for example currently we have to use @ts-ignore when setting |
|
We should really update the official @types/react-native project, to include the windows properties. |
rectified95
reviewed
Sep 21, 2021
| * See https://github.com/ReactWindows/discussions-and-proposals/blob/harinik-accessibility/proposals/0000-accessibilityapis-lists.md | ||
| */ | ||
| accessibilitySetSize?: number; | ||
| focusable?: boolean; |
There was a problem hiding this comment.
Did you remove this prop on purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides better type information for some of the additional properties that we've added to view in react-native-windows.
These properties are available by using
import {ViewWindows} from 'react-native-windows'instead ofimport {View} from 'react-native'Microsoft Reviewers: Open in CodeFlow