Skip to content

Health check code doesn't handle paths with spaces #8625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Sep 15, 2021
Merged

Health check code doesn't handle paths with spaces #8625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
873865b
Better handle spaces in project path
acoates-ms Sep 14, 2021
c1f1e50
Change files
acoates-ms Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@react-native-windows-cli-351665bb-29ec-4fb8-93fa-fa627d7d4d18.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Better handle spaces in project path",
"packageName": "@react-native-windows/cli",
"email": "[email protected]",
"dependentChangeType": "patch"
}
6 changes: 3 additions & 3 deletions packages/@react-native-windows/cli/src/healthChecks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function getHealthChecks(): HealthCheckCategory[] | undefined {
'react-native-windows/package.json',
{paths: [process.cwd()]})), 'Scripts/rnw-dependencies.ps1');

const rnwDeps = execSync(`powershell -ExecutionPolicy Unrestricted -NoProfile ${rnwDepScriptPath} -NoPrompt -ListChecks`);
const rnwDeps = execSync(`powershell -ExecutionPolicy Unrestricted -NoProfile "${rnwDepScriptPath}" -NoPrompt -ListChecks`);
const deps = rnwDeps.toString().trim().split('\n');
return [
{
Expand All @@ -39,7 +39,7 @@ export function getHealthChecks(): HealthCheckCategory[] | undefined {
getDiagnostics: async () => {
let needsToBeFixed = true;
try {
await execa(`powershell -ExecutionPolicy Unrestricted -NoProfile ${rnwDepScriptPath} -NoPrompt -Check ${id}`);
await execa(`powershell -ExecutionPolicy Unrestricted -NoProfile "${rnwDepScriptPath}" -NoPrompt -Check ${id}`);
needsToBeFixed = false;
} catch {
}
Expand All @@ -48,7 +48,7 @@ export function getHealthChecks(): HealthCheckCategory[] | undefined {
}
},
runAutomaticFix: async ({ loader, logManualInstallation }) => {
const command = `powershell -ExecutionPolicy Unrestricted -NoProfile ${rnwDepScriptPath} -Check ${id}`;
const command = `powershell -ExecutionPolicy Unrestricted -NoProfile "${rnwDepScriptPath}" -Check ${id}`;
try {
const { exitCode } = await execa(command, { stdio: 'inherit' });
if (exitCode) {
Expand Down