[api-extractor] add support for cts and mts #4196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfaith
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
|
@microsoft-github-policy-service agree |
michaelfaith
force-pushed
the
feat/support-mts-cts
branch
from
a73820b to
cae52b1
Compare
|
Resolved |
michaelfaith
force-pushed
the
feat/support-mts-cts
branch
from
cae52b1 to
d7b3146
Compare
Since TS 4.7, two new type declaration extensions have been supported: - `.d.cts` for types from a compilation on `.cts` files - `.d.mts` for types from a compilation on `.mts` files Support has been added for both of these type declarations. I also included two new test packages, demonstrating the full .cts -> .cjs/.d.cts and .mts -> .mjs/.d.mts workflow
michaelfaith
force-pushed
the
feat/support-mts-cts
branch
from
d7b3146 to
33591fa
Compare
|
Updated |
|
This would be great since there are dts plugins that rely on api extractor and this could really help those of us who publish dual module system packages and need to provide typings for two modules |
|
@octogonz any feedback on this change? |
|
I am on vacation, will be back next week |
|
Hi @octogonz, are you still going to be looking at this? |
…mts-cts # Conflicts: # apps/api-extractor/src/api/ExtractorConfig.ts # build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml
octogonz
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since TS 4.7, two new type declaration extensions have been supported:
.d.ctsfor types from a compilation on.ctsfiles.d.mtsfor types from a compilation on.mtsfilesSupport has been added for both of these type declarations. I also included two new test packages,
demonstrating the full
.cts->.cjs/.d.ctsand.mts->.mjs/.d.mtsworkflowFixes #3116