Skip to content

microbenchmark - CPU Stream Benchmark Revise #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

polarG
Copy link
Contributor

@polarG polarG commented May 21, 2025

In the current implementation, the CPU‑stream benchmark code renames the binary before the microbench base class can verify its existence, causing the default‐binary check to fail.

This PR adds a “default” binary—built with the standard compile parameters—so that the base class can always find and validate it. Once the default binary is in place, the CPU‑stream code will rename it as needed and re‑check its presence before running the benchmark.

The PR also enable CPU stream in the default settings.

@polarG polarG requested a review from a team as a code owner May 21, 2025 17:31
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.06%. Comparing base (3e09048) to head (4e88409).

Files with missing lines Patch % Lines
...chmarks/micro_benchmarks/cpu_stream_performance.py 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   85.67%   86.06%   +0.38%     
==========================================
  Files          99       99              
  Lines        7211     7211              
==========================================
+ Hits         6178     6206      +28     
+ Misses       1033     1005      -28     
Flag Coverage Δ
cpu-python3.10-unit-test 71.76% <50.00%> (+0.39%) ⬆️
cpu-python3.12-unit-test 71.76% <50.00%> (+0.39%) ⬆️
cpu-python3.7-unit-test 71.34% <50.00%> (ø)
cuda-unit-test 83.50% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG enabled auto-merge (squash) May 28, 2025 17:21
@polarG polarG added benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant