Skip to content

Conversation

aacebo
Copy link
Collaborator

@aacebo aacebo commented Aug 27, 2025

  • add default route overrides so default routes registered by the app can be overridden by the user
  • add tests for router
  • add more options to SignInOptions to make it easier to use Unclear usage of overrideSignInActivity #316

bug: #319

@yuqizhou77
Copy link

I think with overrideSignInActivity, the SDK will still call token service like const resource = await this.api.bots.signIn.getResource({ state }); and this.api.users.token.get, which will fail if user choose not to use the bot service and OAuth connection for auth.

@aacebo
Copy link
Collaborator Author

aacebo commented Aug 29, 2025

I think with overrideSignInActivity, the SDK will still call token service like const resource = await this.api.bots.signIn.getResource({ state }); and this.api.users.token.get, which will fail if user choose not to use the bot service and OAuth connection for auth.

that is correct, our signin method uses our sign in flow, if the developer wants to override the exchange or verify state activities and do their own oauth they can, but they would not use our signin method in that case.

@aacebo aacebo merged commit f9502b9 into main Aug 29, 2025
5 checks passed
@aacebo aacebo deleted the aacebo/316 branch August 29, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants