Skip to content

Ensure we detect userTests with build.sh #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2023

Conversation

jakebailey
Copy link
Member

If you look at https://typescript.visualstudio.com/TypeScript/_build/results?buildId=153671&view=logs&j=98775127-73cc-5696-36a2-d2fef8930518&t=d9d396e3-92f1-565f-9165-fe54ddb28c95, it went from sugar straight to ts-toolbelt, skipping over test262.

It turns out that the function which reads out the userTests doesn't detect build.sh files.

As far as I can tell, this is just an oversight, and including them should "just work"?

@jakebailey
Copy link
Member Author

The diff when running listUserTestRepos, for reference:

diff --git a/before.pretty.json b/after.pretty.json
index 1e56fef..573d50b 100644
--- a/before.pretty.json
+++ b/after.pretty.json
@@ -44,6 +44,9 @@
       "node"
     ]
   },
+  {
+    "name": "azure-sdk"
+  },
   {
     "name": "bcryptjs"
   },
@@ -53,6 +56,9 @@
   {
     "name": "bluebird"
   },
+  {
+    "name": "chrome-devtools-frontend-next"
+  },
   {
     "name": "clear-require"
   },
@@ -164,12 +170,18 @@
   {
     "name": "octokit-rest"
   },
+  {
+    "name": "office-ui-fabric"
+  },
   {
     "name": "portfinder"
   },
   {
     "name": "postcss"
   },
+  {
+    "name": "prettier"
+  },
   {
     "name": "protobufjs"
   },
@@ -179,6 +191,9 @@
     "types": [],
     "branch": "main"
   },
+  {
+    "name": "pyright"
+  },
   {
     "name": "redux"
   },
@@ -188,6 +203,9 @@
   {
     "name": "rxjs"
   },
+  {
+    "name": "rxjs-src"
+  },
   {
     "name": "should"
   },
@@ -200,6 +218,9 @@
   {
     "name": "sugar"
   },
+  {
+    "name": "test262"
+  },
   {
     "name": "ts-toolbelt"
   },
@@ -215,9 +236,15 @@
   {
     "name": "util"
   },
+  {
+    "name": "vscode"
+  },
   {
     "name": "vue"
   },
+  {
+    "name": "vue-next"
+  },
   {
     "name": "vuex"
   },

@jakebailey
Copy link
Member Author

Willing to give this a shot and revert if something goes wrong.

@jakebailey jakebailey merged commit e637969 into microsoft:main May 2, 2023
@jakebailey jakebailey deleted the fix-build-sh-tests branch May 2, 2023 22:42
@jakebailey
Copy link
Member Author

Turns out that the build scripts don't seem to work at all; even though test262 should definitely error, it does not in CI. I don't think the current infra handles errors within these scripts very well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants