Restore test repos to post-install state before starting second compile #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
approved these changes
Feb 21, 2024
jakebailey
commented
Feb 21, 2024
src/main.ts
Outdated
| if (gitAddInstalled) { | ||
| // Force add all of the ignored files we just installed so we can git clean to go back to this state later. | ||
| console.log("Staging all installed files"); | ||
| await execAsync(repoDir, "git add --force ."); |
There was a problem hiding this comment.
On second thought, I should probably just move this out into the tsc runner.
jakebailey
added a commit
to jakebailey/typescript-error-deltas
that referenced
this pull request
Feb 24, 2024
…nd compile (microsoft#131)" This reverts commit 5bb6f7f.
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this should fix most of the weirdness seen in PR runs; we were running tsc twice, but the second run was different because it had the results of the first tsc run. Some repos have tsconfigs we heuristically choose to run which place files in weird places that affect other runs, so it's more desirable to go back to the same state when running a second time.