Emit Time Pretty Slow on M3 Max MacBook

[hrueger]

Hi,
I really like this project. I wanted to reproduce the 10x speedup shown here. However, on my M3 Max MacBook, results for compiling VSCode look like this:

In addition, my Mac freezes completely for 10 - 15s while compiling with tsgo, but I believe it is using all cores.
Did I do something wrong or is it currently only optimized for windows?
Thanks in advance!

[jakebailey]

We're not "optimized for Windows", no. It seems like your IO write performance is pretty bad.

@andrewbranch Do you see this in your own testing?

[hrueger]

I just tried this patch and it works great 🎉

index 6cfd867e..8b2e246f 100644
--- a/internal/vfs/osvfs/os.go
+++ b/internal/vfs/osvfs/os.go
@@ -121,6 +121,8 @@ func osFSRealpath(path string) string {
 }
 
 func (vfs *osFS) writeFile(path string, content string, writeByteOrderMark bool) error {
+	osReadSema <- struct{}{}
+	defer func() { <-osReadSema }()
 	file, err := os.Create(path)
 	if err != nil {
 		return err

[jakebailey]

Alright, clearly we need an IO limiter on writes too. And maybe other IO?

[hrueger]

Cool, that was an easy fix then ;-) Let me know if I should test something else, too 👍

[jakebailey]

Moved to #525, since this is a bug, not a Q&A.