Destructured JSDoc Arguments No Longer Collectively Typeable Using Arbitrary Name

[LukeAbby]

On Strada this snippet works fine:

/**
 * @param {{ foo: number; bar: string }} args
 */
function foo({ foo, bar }) {}

Resulting in this .d.ts file:

/**
 * @param {{ foo: number; bar: string }} args
 */
declare function foo({ foo, bar }: {
    foo: number;
    bar: string;
}): void;

However in Corsa it appears that this has no effect and foo and bar are typed as any.

CC @sandersn. Was this something intentionally left out of the JSDoc port or just something not yet implemented?

[jakebailey]

"has no effect" as in the declaration file is wrong, or that the types themselves are wrong when you hover them or similar?

[LukeAbby]

Has no effect as in the generated .d.ts file is now:

/**
 * @param {{ foo: number; bar: string }} args
 */
declare function foo({ foo, bar }: {
    bar: any;
    foo: any;
}): void;

I said no effect because I could've just as easily put gibberish in the JSDoc and gotten the same output.

[jakebailey]

I'm not surprised by that, we don't even test declaration emit from JS files yet (#1211), let alone think it works.

[LukeAbby]

Ah, that makes me inclined to close this issue but I can leave this issue open for tracking if you would like. In hindsight it makes sense that @param edge cases wouldn't necessarily work. I guess I got fooled by the main @param cases functioning perfectly.

[a-tarasyuk]

@jakebailey I think PR #1241 should cover this case as well - jsdocDestructuringParameterDeclaration.js