Update submodule, fix JSON syntax problems #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the submodule to accommodate the new type ordering changes and fixes test baselines for invalid JSON syntax. Key changes include removal of trailing commas and whitespace adjustments in JSON benchmark files as well as updates to the expected error and type outputs in several diff baselines.
Reviewed Changes
Copilot reviewed 110 out of 110 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| conformance/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).errors.txt.diff | Removed a trailing comma from the package JSON to fix JSON syntax issues. |
| conformance/nodeModulesConditionalPackageExports(module=nodenext).types.diff | Revised expected type outputs (e.g. switching from "any" to the correct inferred types) in alignment with the updated submodule logic. |
| Other diff files | Similar minor formatting and output adjustments across error and types baseline files to reflect updated behavior. |
Comments suppressed due to low confidence (2)
testdata/baselines/reference/submoduleAccepted/conformance/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).errors.txt.diff:61
- The removal of the trailing comma in the package JSON fixes invalid syntax; please ensure that similar JSON files across the baselines remain consistent with this updated syntax.
- "type": "module"
testdata/baselines/reference/submodule/conformance/nodeModulesConditionalPackageExports(module=nodenext).types.diff:1
- The expected type outputs have been updated (e.g. from 'any' to the correct type), which is aligned with the submodule changes; please verify that these new baselines accurately reflect the intended behavior.
--- old.nodeModulesConditionalPackageExports(module=nodenext).types
jakebailey
commented
Jun 24, 2025
| >matches : Iterable<[id2: string, object]> | ||
| >x.get(id1) : Iterable<[id2: string, object]> | ||
| ->x.get : <Key extends [id1: string, id2: string] | [id1: string] | []>(...key: Key) => GetResult<[id1: string, id2: string], Key, object> | ||
| +>x.get : <Key extends [] | [id1: string] | [id1: string, id2: string]>(...key: Key) => GetResult<[id1: string, id2: string], Key, object> |
There was a problem hiding this comment.
For some reason the ordering I have in the submodule does not match for this one case. I'll have to recheck it for mistakes.
There was a problem hiding this comment.
I found one bug, but it was benign. Not sure where this difference comes from.
DanielRosenwasser
approved these changes
Jun 24, 2025
zshannon
added a commit
to zshannon/typescript-go
that referenced
this pull request
Jun 25, 2025
* Update submodule, fix JSON syntax problems (microsoft#1285) * Pool EmitContext (microsoft#1287) --------- Co-authored-by: Jake Bailey <[email protected]>
zshannon
added a commit
to zshannon/typescript-go
that referenced
this pull request
Jul 2, 2025
* Update submodule, fix JSON syntax problems (microsoft#1285) * Pool EmitContext (microsoft#1287) --------- Co-authored-by: Jake Bailey <[email protected]>
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
added a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
* Update submodule, fix JSON syntax problems (microsoft#1285) * Pool EmitContext (microsoft#1287) --------- Co-authored-by: Jake Bailey <[email protected]>
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
added a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
* Update submodule, fix JSON syntax problems (microsoft#1285) * Pool EmitContext (microsoft#1287) --------- Co-authored-by: Jake Bailey <[email protected]>
zshannon
added a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
* Update submodule, fix JSON syntax problems (microsoft#1285) * Pool EmitContext (microsoft#1287) --------- Co-authored-by: Jake Bailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in the type ordering change, as well as test fixes for invalid JSON.