fix: make ResponseMessage.Result omitzero

[skewb1k]

According to the JSON-RPC specification, a response object must include either a result field or an error field, but not both.

Without omitzero, if Result is nil, it is marshalled as 'null', causing both result and error fields to appear in the JSON object when Error is also present, which violates the specification.

[jakebailey]

What client are you using that is so strict?

[skewb1k]

What client are you using that is so strict?

Neovim on the master branch. This is actually caused by my pull request that added the capability to distinguish between null and undefined fields, so now it can detect responses like {result: null, error: {}}. I agree it might be too strict and should be ignored, relying only on the presence of the error field. These two flaws actually help catch each other :).
Still, I think it’s good practice for servers not to violate the JSON-RPC spec.

[jakebailey]

LGTM but since I pushed to it last, I can no longer approve and merge it 😅

[jakebailey]

Technically you could merge main and then I could merge the PR 😉

[jakebailey]

Thanks!

[skewb1k]

Technically you could merge main and then I could merge the PR 😉

Wow, it feels like this shouldn’t work that way.

[jakebailey]

Sorta kinda, I could have also sent code via GitHub code suggestions and you could have merged them in via the UI and it would still commit "as me" and do the same thing, so, oh well.