-
Notifications
You must be signed in to change notification settings - Fork 15
Handle Azure MFA challenges #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure Container Registry client creation to handle Azure MFA challenges by migrating from deprecated APIs to the new createAzureClient
pattern that properly manages authentication flows. The changes standardize client creation across the codebase and upgrade Azure extension dependencies.
- Replace deprecated
createAzureContainerRegistryClient
function with unified client creation pattern - Standardize authentication context handling for MFA support
- Update Azure extension dependencies to latest versions
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/utils/azureUtils.ts | Refactored client creation functions to use new authentication pattern |
src/tree/registries/Azure/AzureRegistryDataProvider.ts | Updated registry operations to use new client creation and MFA-aware context |
src/tree/registries/Azure/createWizard/AzureRegistryNameStep.ts | Migrated to new client creation pattern |
src/tree/registries/Azure/createWizard/AzureRegistryCreateStep.ts | Updated client creation and removed explicit type annotation |
src/commands/registries/azure/tasks/scheduleRunRequest.ts | Migrated to new client creation with proper context |
src/commands/registries/azure/deployImageToAzure.ts | Removed unused import and explicit type annotation |
src/commands/registries/azure/WebSitesPortPromptStep.ts | Added type keyword to import |
src/commands/registries/azure/DockerWebhookCreateStep.ts | Updated to use new client creation and proper type annotations |
src/commands/registries/azure/DockerSiteCreateStep.ts | Updated client creation and removed explicit type annotations |
src/commands/registries/azure/DockerAssignAcrPullRoleStep.ts | Migrated to new client creation pattern |
src/commands/registries/azure/ACROAuthProvider.ts | Consolidated imports |
src/utils/getHandlebarsWithHelpers.ts | Reorganized imports and updated type annotation |
package.json | Updated Azure extension dependencies to latest versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes #200, fixes #209
Please see the above issue and microsoft/vscode-azureresourcegroups#1200 for background information.
Need to test:
* These are not expected to be affected, but I am testing anyways