Skip to content

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Aug 21, 2025

Fixes #200, fixes #209

Please see the above issue and microsoft/vscode-azureresourcegroups#1200 for background information.

Need to test:

* These are not expected to be affected, but I am testing anyways

@bwateratmsft bwateratmsft requested a review from a team as a code owner August 21, 2025 20:21
@bwateratmsft bwateratmsft requested a review from Copilot August 21, 2025 20:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Container Registry client creation to handle Azure MFA challenges by migrating from deprecated APIs to the new createAzureClient pattern that properly manages authentication flows. The changes standardize client creation across the codebase and upgrade Azure extension dependencies.

  • Replace deprecated createAzureContainerRegistryClient function with unified client creation pattern
  • Standardize authentication context handling for MFA support
  • Update Azure extension dependencies to latest versions

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/utils/azureUtils.ts Refactored client creation functions to use new authentication pattern
src/tree/registries/Azure/AzureRegistryDataProvider.ts Updated registry operations to use new client creation and MFA-aware context
src/tree/registries/Azure/createWizard/AzureRegistryNameStep.ts Migrated to new client creation pattern
src/tree/registries/Azure/createWizard/AzureRegistryCreateStep.ts Updated client creation and removed explicit type annotation
src/commands/registries/azure/tasks/scheduleRunRequest.ts Migrated to new client creation with proper context
src/commands/registries/azure/deployImageToAzure.ts Removed unused import and explicit type annotation
src/commands/registries/azure/WebSitesPortPromptStep.ts Added type keyword to import
src/commands/registries/azure/DockerWebhookCreateStep.ts Updated to use new client creation and proper type annotations
src/commands/registries/azure/DockerSiteCreateStep.ts Updated client creation and removed explicit type annotations
src/commands/registries/azure/DockerAssignAcrPullRoleStep.ts Migrated to new client creation pattern
src/commands/registries/azure/ACROAuthProvider.ts Consolidated imports
src/utils/getHandlebarsWithHelpers.ts Reorganized imports and updated type annotation
package.json Updated Azure extension dependencies to latest versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

alexweininger
alexweininger previously approved these changes Aug 21, 2025
@bwateratmsft bwateratmsft enabled auto-merge (squash) September 11, 2025 16:01
@bwateratmsft bwateratmsft merged commit 6a8643d into main Sep 11, 2025
2 checks passed
@bwateratmsft bwateratmsft deleted the bmw/azureMFA branch September 11, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry V2: inspect image manifest and delete image (by manifest) are failing with 404 errors Handle new MFA challenges for Azure authentication
3 participants