Skip to content

Don't show bogus errors for compilerPath + args in config UI #13531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Don't show bogus errors for compilerPath + args in config UI #13531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d6657c
Don't show bogus errors for compilerPath + args in config UI
bobbrow Apr 17, 2025
012abee
PR feedback
bobbrow Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Extension/src/LanguageServer/configurations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1617,7 +1617,11 @@ export class CppProperties {
}
const settings: CppSettings = new CppSettings(this.rootUri);
const compilerPathAndArgs: util.CompilerPathAndArgs = util.extractCompilerPathAndArgs(!!settings.legacyCompilerArgsBehavior, resolvedCompilerPath);

// compilerPath + args in the same string isn't working yet.
const skipFullCommandString = !compilerPathAndArgs.compilerName && resolvedCompilerPath.includes(" ");
if (resolvedCompilerPath
&& !skipFullCommandString
// Don't error cl.exe paths because it could be for an older preview build.
&& compilerPathAndArgs.compilerName.toLowerCase() !== "cl.exe"
&& compilerPathAndArgs.compilerName.toLowerCase() !== "cl") {
Expand Down Expand Up @@ -1795,7 +1799,7 @@ export class CppProperties {
if (!this.configurationJson) {
return;
}
if ((this.configurationJson.enableConfigurationSquiggles !== undefined && !this.configurationJson.enableConfigurationSquiggles) ||
if ((this.configurationJson.enableConfigurationSquiggles === false) ||
(this.configurationJson.enableConfigurationSquiggles === undefined && !settings.defaultEnableConfigurationSquiggles)) {
this.diagnosticCollection.clear();
return;
Expand Down