-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: remove Visual Studio-related files for cross-platform cleanup #13702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a569a97
chore: remove Visual Studio-related files for cross-platform cleanup
Subham-KRLX 62189d5
chore: remove build.cmd reference from tasks.json
Subham-KRLX b32e26d
Merge branch 'main' into cleanup/remove-vs-files
Subham-KRLX 3310fe1
Merge branch 'main' into cleanup/remove-vs-files
Subham-KRLX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,41 @@ | ||
| { | ||
| // See https://go.microsoft.com/fwlink/?LinkId=733558 | ||
| // for the documentation about the tasks.json format | ||
| "version": "2.0.0", | ||
| "tasks": [ | ||
| { | ||
| "label": "build", | ||
| "type": "shell", | ||
| "group": { | ||
| "kind": "build", | ||
| "isDefault": true | ||
| }, | ||
| "presentation": { | ||
| "echo": true, | ||
| "reveal": "always", | ||
| "focus": false, | ||
| "panel": "shared" | ||
| }, | ||
| "windows": { | ||
| "command": "${workspaceRoot}/build.cmd", | ||
| "args": [ | ||
| "<Path/To/MinGW/Cygwin/Bin/Folder>", // Path to the bin folder containing g++ to compile | ||
| "fib.exe" // Output executable name | ||
| ] | ||
| }, | ||
| "linux": { | ||
| "command": "g++", | ||
| "args": [ | ||
| "-g", | ||
| "*.cpp", | ||
| "-lpthread", | ||
| "--std=c++11", | ||
| "-o", | ||
| "fib.out" | ||
| ] | ||
| }, | ||
| "osx": { | ||
| "command": "g++", | ||
| "args": [ | ||
| "-g", | ||
| "*.cpp", | ||
| "-lpthread", | ||
| "--std=c++11", | ||
| "-o", | ||
| "fib.out" | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| "version": "2.0.0", | ||
| "tasks": [ | ||
| { | ||
| "label": "build", | ||
| "type": "shell", | ||
| "group": { | ||
| "kind": "build", | ||
| "isDefault": true | ||
| }, | ||
| "presentation": { | ||
| "echo": true, | ||
| "reveal": "always", | ||
| "focus": false, | ||
| "panel": "shared" | ||
| }, | ||
| "linux": { | ||
| "command": "g++", | ||
| "args": [ | ||
| "-g", | ||
| "*.cpp", | ||
| "-lpthread", | ||
| "--std=c++11", | ||
| "-o", | ||
| "fib.out" | ||
| ] | ||
| }, | ||
| "osx": { | ||
| "command": "g++", | ||
| "args": [ | ||
| "-g", | ||
| "*.cpp", | ||
| "-lpthread", | ||
| "--std=c++11", | ||
| "-o", | ||
| "fib.out" | ||
| ] | ||
| } | ||
| } | ||
| ] | ||
| } | ||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Subham-KRLX . Wouldn't this prevent this code sample from working correctly on Windows (i.e. with MinGW G++) ? I think we would want to retain the window specific arguments section.
I believe the
build.cmdfile is working around a known issue with MinGW that requires its bin directory to be in path when run, in order to properly resolve dependent DLLs. It may be possible to move that work-around into the TypeScript code in order to get rid ofbuild.cmd. But I think we would still want to use of this code sample on Windows.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think the see the real issue here. This code sample directly uses pthreads, so does not compile on Windows. I think the ideal fix here would be for the sample to be updated to provide a Windows implementation as well.