Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Adding React devcontainer for creating react apps #63

Closed
wants to merge 5 commits into from

Conversation

kmehant
Copy link
Contributor

@kmehant kmehant commented Jun 1, 2019

Context

Adding React devcontainer for creating react apps in Linux containers with vscode remote

@kmehant
Copy link
Contributor Author

kmehant commented Jun 1, 2019

This PR can be part of these #14 accomplishments.
@Chuxel @egamma @qubitron I wish this PR gets reviewed 😄

@Chuxel
Copy link
Member

Chuxel commented Jun 6, 2019

This one feels a bit too close to other node.js based definitions already in the repository. These are also intended to be used with existing projects, so calling the create-react-app CLI would actually cause problems. Thanks for the contribution though!

@Chuxel Chuxel closed this Jun 6, 2019
@kmehant kmehant deleted the react-devcontainer branch June 21, 2019 03:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants