Skip to content

switch to warning if launch.json missing version #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

switch to warning if launch.json missing version #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/extension/debugger/configuration/launch.json/launchJsonReader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import * as fs from 'fs-extra';
import { parse } from 'jsonc-parser';
import { DebugConfiguration, Uri, WorkspaceFolder } from 'vscode';
import { getConfiguration, getWorkspaceFolder } from '../../../common/vscodeapi';
import { traceLog } from '../../../common/log/logging';
import { traceError, traceLog, traceWarn } from '../../../common/log/logging';

export async function getConfigurationsForWorkspace(workspace: WorkspaceFolder): Promise<DebugConfiguration[]> {
traceLog('Getting configurations for workspace');
Expand All @@ -23,10 +23,11 @@ export async function getConfigurationsForWorkspace(workspace: WorkspaceFolder):
}
// configurations found in launch.json, verify them then return
if (!Array.isArray(parsed.configurations) || parsed.configurations.length === 0) {
traceError('Invalid configurations in launch.json');
throw Error('Invalid configurations in launch.json');
}
if (!parsed.version) {
throw Error('Missing field in launch.json: version');
traceWarn('Missing field in launch.json: version');
}
traceLog('Using configuration in launch.json');
return parsed.configurations;
Expand Down
Loading