Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Add warning about running python code in the extension #102

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

LukeSlev
Copy link
Member

@LukeSlev LukeSlev commented Aug 8, 2019

Description:

This PR adds a warning to the user that the code they are running is being run on their actual computer

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing:

  • make sure that running the simulator pops up the notification
  • cancel doesn't run the code
  • accept and run runs code and you never see the notification again

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and works as described.

@LukeSlev LukeSlev merged commit be07d8d into dev Aug 9, 2019
@jonathanwangg jonathanwangg deleted the users/t-luslev/python-code-warning branch August 26, 2019 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants