-
Notifications
You must be signed in to change notification settings - Fork 48
Solving bug with input and capacitive touch #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out alt keys actually overlap with vs code short cuts 😓 if you have multiple editors in one column it changes between them.. I suppose we should switch alt to shift or something 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding OnHover back to A7 :)
I just have a question, it looks like we can select more than one touch sensor at a time ? I tried holding shift+1+2
It will send the events correctly but the CSS will only be activated for one touch sensor. I feel like this might not be what we want ?
EDIT
Talking with Michelle and Luke, it seems like multiple focus (blue boarder) is not possible, but maybe it could be more interesting to at least have the orange boarder for the selected touch sensors with keys presses (like buttons A&B, same style as mouse click).
I added that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you !
Looks good enough for now
Description:
This PR solve the bug introduce after by the capacitive touch in the input slider. That bug prevented the user from typing value in the input box of the slider triggering the capacitive touch instead.
The capacitive touch has now been changed and instead of being triggered by numeric keys only, it is triggered by Shift + numkey
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Checklist: