Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Solving bug with input and capacitive touch #111

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Conversation

FMounz
Copy link
Contributor

@FMounz FMounz commented Aug 13, 2019

Description:

This PR solve the bug introduce after by the capacitive touch in the input slider. That bug prevented the user from typing value in the input box of the slider triggering the capacitive touch instead.
The capacitive touch has now been changed and instead of being triggered by numeric keys only, it is triggered by Shift + numkey

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Limitations:

Please describe limitations of this PR

Testing:

  • Make sure you can now use the slider without issue and that Shift + numkey triggers the capacitive touch

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out alt keys actually overlap with vs code short cuts 😓 if you have multiple editors in one column it changes between them.. I suppose we should switch alt to shift or something 🤷‍♂️

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Christellah Christellah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding OnHover back to A7 :)

I just have a question, it looks like we can select more than one touch sensor at a time ? I tried holding shift+1+2
It will send the events correctly but the CSS will only be activated for one touch sensor. I feel like this might not be what we want ?

EDIT
Talking with Michelle and Luke, it seems like multiple focus (blue boarder) is not possible, but maybe it could be more interesting to at least have the orange boarder for the selected touch sensors with keys presses (like buttons A&B, same style as mouse click).

@FMounz
Copy link
Contributor Author

FMounz commented Aug 14, 2019

Thanks for adding OnHover back to A7 :)
I just have a question, it looks like we can select more than one touch sensor at a time ? I tried holding shift+1+2
It will send the events correctly but the CSS will only be activated for one touch sensor. I feel like this might not be what we want ?
EDIT
Talking with Michelle and Luke, it seems like multiple focus (blue boarder) is not possible, but maybe it could be more interesting to at least have the orange boarder for the selected touch sensors with keys presses (like buttons A&B, same style as mouse click).

I added that.

Copy link
Contributor

@Christellah Christellah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !
Looks good enough for now

@FMounz FMounz merged commit 7dd6523 into dev Aug 14, 2019
@FMounz FMounz deleted the users/t-famoun/input-bug-fix branch August 15, 2019 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants