This repository was archived by the owner on Dec 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pinsight-telemetry
LukeSlev
suggested changes
Aug 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to look at here!
@FMounz conflicts again |
@FMounz conflicts again |
@FMounz conflicts |
markAtMicrosoft
suggested changes
Aug 19, 2019
markAtMicrosoft
approved these changes
Aug 19, 2019
Discussed offline we really only want to track feature usage per run not total times the method was called. |
LukeSlev
reviewed
Aug 19, 2019
LukeSlev
reviewed
Aug 19, 2019
LukeSlev
reviewed
Aug 19, 2019
LukeSlev
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds Telemetry for the new features. The usage of the sensors is tracked as well as the non implemented functions that the user might try to use.
To do so Application Insights for python has been used.
Type of change
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Telemetry added:
'TAPPED': "API.TAPPED",
'PLAY_FILE': "API.PLAY.FILE",
'PLAY_TONE': "API.PLAY.TONE",
'START_TONE': "API.START.TONE",
'STOP_TONE': "API.STOP.TONE",
'DETECT_TAPS': "API.DETECT.TAPS",
'ADJUST_THRESHOLD': "API.ADJUST.THRESHOLD",
'RED_LED': "API.RED.LED",
'PIXELS': "API.PIXELS"
SIMULATOR_TEMPERATURE_SENSOR = "SIMULATOR.TEMPERATURE",
SIMULATOR_LIGHT_SENSOR = " SIMULATOR.LIGHT",
SIMULATOR_MOTION_SENSOR = "SIMULATOR.MOTION",
SIMULATOR_SHAKE = "SIMULATOR.SHAKE",
SIMULATOR_CAPACITIVE_TOUCH = "SIMULATOR.CAPACITIVE.TOUCH",
Checklist: