Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Make CPX svg responsive #128

Merged
merged 6 commits into from
Aug 20, 2019
Merged

Make CPX svg responsive #128

merged 6 commits into from
Aug 20, 2019

Conversation

FMounz
Copy link
Contributor

@FMounz FMounz commented Aug 20, 2019

Description:

This PR adjust the size of the CPX (board simulator SVG) to make it responsive.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

This PR concerns only the CPX so the elements around it have not been resized.
In order to meet some design requirements, the responsiveness have been limited so the simulator doesn't get too big or too small.

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Open the WebView, resize the window, make sure the CPX is responsive

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It would be ideal if we could center this always, but not a huge thing

That is due to the size restriction I am mentioning in the limitations. But I discussed with the designer and we are trading the min size for the svg being always centered

@FMounz
Copy link
Contributor Author

FMounz commented Aug 20, 2019

It would be ideal if we could center this always, but not a huge thing
That is due to the size restriction I am mentioning in the limitations. But I discussed with the designer and we are trading the min size for the svg being always centered

It would be ideal if we could center this always, but not a huge thing
That is due to the size restriction I am mentioning in the limitations. But I discussed with the designer and we are trading the min size for the svg being always centered

image

@jonathanwangg
Copy link
Contributor

There appears to be some kind of resizing issue where the webview gets enlarged from first press of the Simulator buttons / control panel buttons.

To reproduce:

  1. Start the extension in the Extension Development Host
  2. Make sure there are two panels (one on right, one on left) where the panel on the right is as small as possible (refer to image)
    image
  3. Click show simulator button
  4. Click on one of the icons in the control panel
  5. Notice that the entire webview is rescaled

Talked offline: appears to be an existing issue and not specific to this PR.

@FMounz FMounz merged commit 0ae9c00 into dev Aug 20, 2019
@jonathanwangg jonathanwangg deleted the users/t-famoun/responsive-ui branch August 26, 2019 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants