Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Install dependencies for users #135

Merged
merged 7 commits into from
Aug 22, 2019
Merged

Conversation

LukeSlev
Copy link
Member

Description:

This PR makes it so that users are prompted to have the python dependencies installed for them

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

We don't check if they need the pop up, we always pop up the option as running the install command when you already have the packages doesn't error out

Testing:

  • should be able to install all python dependencies through the pop up

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@markAtMicrosoft markAtMicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the https://github.com/microsoft/vscode-python-embedded/blob/dev/docs/developers-setup.md file to match the changes for dependencies. Maybe should tell them before they type all those pip commands in that the extension will do it for them on execution.

@jonathanwangg
Copy link
Contributor

jonathanwangg commented Aug 21, 2019

Conflicts

@LukeSlev LukeSlev merged commit 418bcd9 into dev Aug 22, 2019
@jonathanwangg jonathanwangg deleted the users/t-luslev/install-dependencies branch August 26, 2019 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants