Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Fix lack of null check on currentActiveFile #136

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fix lack of null check on currentActiveFile #136

merged 1 commit into from
Aug 21, 2019

Conversation

LukeSlev
Copy link
Member

Description:

This PR is a bug fix for if you try to run no file

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing:

  • open the simulator with no files open and press play, should not blow up

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@LukeSlev LukeSlev changed the title Rix lack of null check on currentActiveFile Fix lack of null check on currentActiveFile Aug 21, 2019
FMounz
FMounz approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@FMounz FMounz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@LukeSlev LukeSlev merged commit e4e73f2 into dev Aug 21, 2019
@jonathanwangg jonathanwangg deleted the users/t-luslev/fix-no-active-file-run branch August 26, 2019 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markAtMicrosoft markAtMicrosoft markAtMicrosoft approved these changes

@FMounz FMounz FMounz approved these changes

@jonathanwangg jonathanwangg Awaiting requested review from jonathanwangg

@Christellah Christellah Awaiting requested review from Christellah

@abmahdy abmahdy Awaiting requested review from abmahdy abmahdy is a code owner

@adclements adclements Awaiting requested review from adclements adclements is a code owner

@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukeSlev @markAtMicrosoft @FMounz