This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Update test message for serial monitor #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanwangg
requested review from
smmatte,
Christellah,
LukeSlev,
markAtMicrosoft,
adclements,
FMounz and
abmahdy
smmatte
approved these changes
Aug 23, 2019
Christellah
approved these changes
Aug 23, 2019
| @@ -73,7 +73,7 @@ export class SerialPortControl { | |||
| this._currentSerialPort = new SerialPortControl.serialport(this._currentPort, { baudRate: this._currentBaudRate }); | |||
| this._outputChannel.show(); | |||
| this._currentSerialPort.on("open", () => { | |||
| this._currentSerialPort.write("msft", "Both NL & CR", (err: any) => { | |||
| this._currentSerialPort.write(CONSTANTS.MISC.SERIAL_MONITOR_TEST_IF_OPEN, "Both NL & CR", (err: any) => { | |||
| if (err && !(err.message.indexOf(CONSTANTS.ERROR.COMPORT_UNKNOWN_ERROR) >= 0)) { | |||
| logToOutputChannel(this._outputChannel, CONSTANTS.ERROR.FAILED_TO_OPEN_SERIAL_PORT(this._currentPort)); | |||
There was a problem hiding this comment.
Can we add after that line another logToOutputChannel telling them to try re-plugging the device?
There was a problem hiding this comment.
Yeah, I'm pretty sure we can add another line that prints to an OutputChannel if an error occurs. Do you think logging to the Pacifica Simulator Output Channel is more appropriate?
In my opinion, it would be hard to guide the user based on what the error code is. Best thing to do would be directing the user to unplug the device, re-plug it and try again. Do you think that would be sufficient given our time frame? |
Christellah
approved these changes
Aug 23, 2019
jonathanwangg
deleted the
users/t-jowang/update-test-message-serial-monitor
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In this PR, I'm updating the message we're sending to test if the serial port is open. Previously, the message wasn't informative enough to the user.
Type of change
Limitations:
None
Testing:
Can't really reliably test this since we only see the message if the serial port errors out.
Checklist: