Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Update package.json for marketplace #159

Merged
merged 3 commits into from
Nov 28, 2019

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Nov 10, 2019

From the VS Code Python team, adding a link to the repo to add visibility to the source repo on the marketplace.

Description:

  • Looking at the marketplace its not easy to find the source for the repo (its open source, but finding the source is not possible).
    This PR will add the link to the repo.
  • Searching for this extension is improved with addition of keywords (Adafruit, circuit python and python).

Type of change

  • Updates to the package.json file

Please delete options that are not relevant.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [n/a] Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additions look great. Can the indentation of the activationEvents key be fixed before this PR is approved?

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the indentation? Otherwise, this is a great update. Thank you!

modifying the indentation to match the rest of the structure
one last spacing to fix.
@iennae
Copy link
Contributor

iennae commented Nov 28, 2019

I've gone ahead and fixed the indentation. Thanks again for the contribution.

@iennae iennae merged commit 5786936 into microsoft:dev Nov 28, 2019
@DonJayamanne
Copy link
Contributor Author

Thanks, forgot about this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants