Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Added unit tests and removed some unused test code #174

Merged
merged 29 commits into from
Jan 28, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Jan 22, 2020

Description:

Added unit tests and removed some unused test code

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vandyliu vandyliu requested a review from nasadigital January 22, 2020 17:54
@vandyliu vandyliu changed the title WIP: Users/t vali/python tests Added unit tests and removed some unused test code Jan 23, 2020
@vandyliu vandyliu marked this pull request as ready for review January 23, 2020 06:04
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more tests. Great work! 👍

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the fixes!
LGTM 🥇

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests! Looks fine to me :)

@vandyliu vandyliu merged commit 97b074f into dev Jan 28, 2020
@vandyliu vandyliu deleted the users/t-vali/python-tests branch January 28, 2020 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants