This repository was archived by the owner on Dec 23, 2021. It is now read-only.
micro:bit Image #184
Merged
micro:bit Image #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnkevinnguyen
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
nasadigital
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
LGTM!
I'd have @sagarmanchanda take a look before merging, though.
src/view/components/cpx/CpxImage.tsx
Outdated
| setupKeyPresses(props.onKeyEvent); | ||
| setupSwitch(props); | ||
| firstTime = false; | ||
| // |
There was a problem hiding this comment.
Perhaps remove this or add a comment?
There was a problem hiding this comment.
thanks david, i'll remove this
sagarmanchanda
approved these changes
Feb 4, 2020
| margin-left: auto; | ||
| margin-right: auto; | ||
| .microbit-container { | ||
| max-width: 350px; |
There was a problem hiding this comment.
Why is this not also 100% as cpx?
There was a problem hiding this comment.
There is already some max sizing in the default cpx styling, but not on micro-bit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pr is dependant of this pr #183
The microbit image is rendered under the micro:bit tab.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check