Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Display module for microbit library #189

Merged
merged 45 commits into from
Feb 6, 2020
Merged

Display module for microbit library #189

merged 45 commits into from
Feb 6, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Feb 4, 2020

Description:

Implemented the display module for the microbit library.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for figuring this all out 😎

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on making this faithful to the device! 👍

@vandyliu vandyliu requested a review from nasadigital February 6, 2020 01:22
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the fixes! Just a bit more~

@vandyliu vandyliu requested a review from nasadigital February 6, 2020 18:57
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just address the last comment and LGTM! 🎉

@vandyliu vandyliu merged commit 086250c into dev Feb 6, 2020
@vandyliu vandyliu deleted the users/t-vali/display branch February 6, 2020 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants