This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Added telemetry to typescript side of extension #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandyliu
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
xnkevinnguyen
suggested changes
Feb 20, 2020
src/extension.ts
Outdated
| @@ -172,7 +172,20 @@ export async function activate(context: vscode.ExtensionContext) { | |||
| switch (message.command) { | |||
| case WEBVIEW_MESSAGES.BUTTON_PRESS: | |||
| // Send input to the Python process | |||
| handleButtonPressTelemetry(message.text); | |||
| switch (currentActiveDevice) { | |||
There was a problem hiding this comment.
wondering if there is a better way to do this, then switch cases everywhere. It might become heavy when we have more devices. Potentially wrapper function or maybe adding an argument to the telemetry event if that is possible
There was a problem hiding this comment.
great suggestion. I updated it. Lmk what u think
sagarmanchanda
approved these changes
Feb 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check