Basic functionality for microbit Debugging and fixes #216
Conversation
andreamah
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
xnkevinnguyen
changed the title
src/debuggerCommunicationServer.ts
Outdated
| ); | ||
| }); | ||
| socket.on(DEBUGGER_MESSAGES.LISTENER.RECEIVED_STATE, () => { | ||
| this.isWaitingResponse = false; |
There was a problem hiding this comment.
We can alternatively only assign this to false if this.currentCall.length != 0 -- then we wouldn't need to update this value inside currentCall() again.
There was a problem hiding this comment.
good suggestion! Removed it from current call and setting it to true if this.currentcall.lenth>0. If it's 0, then i'm putting it to false since there's no more calls
There was a problem hiding this comment.
I think we don't need to assign it to true on the listener? Since we won't assign it to false elsewhere. Anyway, it's up to you if you think that's a good sanity check!
There was a problem hiding this comment.
Just a heads up, try to keep only one change per PR (e.g. I noticed we have some stuff for telemetry as well). It's easier to roll back if there is any breaking changes if we keep one thing per insertion.
I think that's all right for now, just to keep that in mind for the next ones!
Description:
Improvements to CPX debugger and addition of microbit debugger.
Type of change
Limitations:
Testing:
Checklist:
npm run formatand passes the checks innpm run check