This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Properly disconnect socket io on exit #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnkevinnguyen
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
xnkevinnguyen
changed the title
|
I think there are some changes from #217 here? If we are depending on that check-in first, it might be easier to complete that one and then rebase |
xnkevinnguyen
changed the title
nasadigital
reviewed
Feb 26, 2020
…m/microsoft/vscode-python-devicesimulator into users/t-anmah/debugger-socket-fix
nasadigital
reviewed
Feb 27, 2020
nasadigital
approved these changes
Feb 27, 2020
| @@ -34,6 +34,7 @@ export class DebugAdapter implements DebugAdapterTracker { | |||
| if (!message.arguments.restart) { | |||
| this.debugCommunicationService.handleStopEvent(); | |||
| } | |||
| break; | |||
There was a problem hiding this comment.
You could also add a default case which would throw an UnsupportedOperationException. Up to you.
Comment on lines
23
to
25
| if (this.previousDebuggerServerToDisconnect) { | ||
| this.previousDebuggerServerToDisconnect.disconnectFromPort(); | ||
| } |
There was a problem hiding this comment.
You can replace lines 23~25 with:
this.previousDebuggerServerToDisconnect?.disconnectFromPort()
Same for other places.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sometimes on restart, socket io does not get disconnected properly on the python side. Restarting it causes a problem since it will try to reconnect on the same port.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
npm run formatand passes the checks innpm run check