Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

micro:bit key presses functionality (accessibility) #222

Merged
merged 57 commits into from
Mar 2, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Feb 26, 2020

Description:

  • Can press 'a' and 'b' to simulate button a and button b being pressed
  • Can press 'c' to simulate AB button
  • Added aria-label for play/stop button to correctly state what it is depending on state
  • Can tab onto a button and press enter to simulate the button being pressed
  • Commented out hover changes for pins

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! c:

@vandyliu vandyliu force-pushed the users/t-vali/keypresses-accessibility branch from cb04798 to 0af304d Compare February 27, 2020 21:19
@vandyliu vandyliu changed the title micro:bit key presses functionality (accessibility) (WIP) micro:bit key presses functionality (accessibility) Feb 28, 2020
@vandyliu vandyliu merged commit 70f553c into dev Mar 2, 2020
@vandyliu vandyliu deleted the users/t-vali/keypresses-accessibility branch March 2, 2020 08:09
@vandyliu vandyliu changed the title (WIP) micro:bit key presses functionality (accessibility) micro:bit key presses functionality (accessibility) Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants