Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Handle active editor undefined #241

Merged
merged 5 commits into from
Mar 5, 2020
Merged

Conversation

xnkevinnguyen
Copy link
Contributor

Description:

To reproduce the problem: close the terminal. Try to play file. File will not play.

this is a fix for that bug.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome !!! Works super well. Great job Kev

Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍦

@xnkevinnguyen xnkevinnguyen changed the title Handle active editor undefined WIP:Handle active editor undefined Mar 4, 2020
@xnkevinnguyen xnkevinnguyen changed the title WIP:Handle active editor undefined Handle active editor undefined Mar 5, 2020
@xnkevinnguyen xnkevinnguyen merged commit b8fcf43 into dev Mar 5, 2020
@xnkevinnguyen xnkevinnguyen deleted the users/t-xunguy/file-selection-fix branch March 10, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants