Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Allows unicode characters (eg. Japanese) in the python files that are run in the simulator #243

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 4, 2020

Description:

  • Allows unicode characters (eg. Japanese) in the python files that are run in the simulator
  • Changed encoding to "utf8" for when files are open

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 😁 Is there a way to add this scenario on our tests?

@vandyliu
Copy link
Contributor Author

vandyliu commented Mar 4, 2020

Nice catch 😁 Is there a way to add this scenario on our tests?

We would probably need to write some larger scale tests. I'll add it to the backlog and hopefully, it is something we can make happen :D

@vandyliu vandyliu merged commit 98c8f33 into dev Mar 4, 2020
@vandyliu vandyliu deleted the users/t-vali/allow-unicode-in-files branch March 4, 2020 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants