Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Extract file selection Service and device selection #244

Merged
merged 10 commits into from
Mar 6, 2020

Conversation

xnkevinnguyen
Copy link
Contributor

Description:

Refactoring task to make the code more readable.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to comment on something that has not been edited by the PR <_<

While you are on it, it would be nice if we could also get rid of all these noisy console.log at extension.ts (I noticed you already removed some of them).

Otherwise, nice clean up! 🎡

@xnkevinnguyen xnkevinnguyen merged commit a79e615 into dev Mar 6, 2020
@xnkevinnguyen xnkevinnguyen deleted the users/t-xunguy/refactor branch March 10, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants